Fixed old, longstanding, and surprisingly bad bug in cleanMemory() for all machine implementations

disks/pcx86/tools/other/flickerfree/README.md

@@ -359,4 +359,3 @@ From the file `FF_HIST`:
 	                                                    Irvine, CA, USA
 	
 	                                - End Of File -
-

modules/pc6502/lib/bus.js

@@ -264,12 +264,14 @@ Bus.prototype.cleanMemory = function(addr, size)
 {
     var fClean = true;
     var iBlock = addr >>> this.nBlockShift;
+    var sizeBlock = this.nBlockSize - (addr & this.nBlockLimit);
     while (size > 0 && iBlock < this.aMemBlocks.length) {
         if (this.aMemBlocks[iBlock].fDirty) {
             this.aMemBlocks[iBlock].fDirty = fClean = false;
             this.aMemBlocks[iBlock].fDirtyEver = true;
         }
-        size -= this.nBlockSize;
+        size -= sizeBlock;
+        sizeBlock = this.nBlockSize;
         iBlock++;
     }
     return fClean;

modules/pc8080/lib/bus.js

@@ -296,12 +296,14 @@ class Bus8080 extends Component {
     {
         var fClean = true;
         var iBlock = addr >>> this.nBlockShift;
+        var sizeBlock = this.nBlockSize - (addr & this.nBlockLimit);
         while (size > 0 && iBlock < this.aMemBlocks.length) {
             if (this.aMemBlocks[iBlock].fDirty) {
                 this.aMemBlocks[iBlock].fDirty = fClean = false;
                 this.aMemBlocks[iBlock].fDirtyEver = true;
             }
-            size -= this.nBlockSize;
+            size -= sizeBlock;
+            sizeBlock = this.nBlockSize;
             iBlock++;
         }
         return fClean;

modules/pcx86/lib/bus.js

@@ -345,12 +345,14 @@ class Bus extends Component {
     {
         var fClean = true;
         var iBlock = addr >>> this.nBlockShift;
+        var sizeBlock = this.nBlockSize - (addr & this.nBlockLimit);
         while (size > 0 && iBlock < this.aMemBlocks.length) {
             if (this.aMemBlocks[iBlock].fDirty) {
                 this.aMemBlocks[iBlock].fDirty = fClean = false;
                 this.aMemBlocks[iBlock].fDirtyEver = true;
             }
-            size -= this.nBlockSize;
+            size -= sizeBlock;
+            sizeBlock = this.nBlockSize;
             iBlock++;
         }
         return fClean;

modules/pdp10/lib/bus.js

@@ -327,12 +327,14 @@ class BusPDP10 extends Component {
     {
         var fClean = true;
         var iBlock = addr >>> this.nBlockShift;
+        var sizeBlock = this.nBlockSize - (addr & this.nBlockLimit);
         while (size > 0 && iBlock < this.aBusBlocks.length) {
             if (this.aBusBlocks[iBlock].fDirty) {
                 this.aBusBlocks[iBlock].fDirty = fClean = false;
                 this.aBusBlocks[iBlock].fDirtyEver = true;
             }
-            size -= this.nBlockSize;
+            size -= sizeBlock;
+            sizeBlock = this.nBlockSize;
             iBlock++;
         }
         return fClean;

modules/pdp11/lib/bus.js

@@ -475,12 +475,14 @@ class BusPDP11 extends Component {
     {
         var fClean = true;
         var iBlock = addr >>> this.nBlockShift;
+        var sizeBlock = this.nBlockSize - (addr & this.nBlockLimit);
         while (size > 0 && iBlock < this.aBusBlocks.length) {
             if (this.aBusBlocks[iBlock].fDirty) {
                 this.aBusBlocks[iBlock].fDirty = fClean = false;
                 this.aBusBlocks[iBlock].fDirtyEver = true;
             }
-            size -= this.nBlockSize;
+            size -= sizeBlock;
+            sizeBlock = this.nBlockSize;
             iBlock++;
         }
         return fClean;

versions/pc8080/1.36.0/pc8080-uncompiled.js

@@ -4565,12 +4565,14 @@ class Bus8080 extends Component {
     {
         var fClean = true;
         var iBlock = addr >>> this.nBlockShift;
+        var sizeBlock = this.nBlockSize - (addr & this.nBlockLimit);
         while (size > 0 && iBlock < this.aMemBlocks.length) {
             if (this.aMemBlocks[iBlock].fDirty) {
                 this.aMemBlocks[iBlock].fDirty = fClean = false;
                 this.aMemBlocks[iBlock].fDirtyEver = true;
             }
-            size -= this.nBlockSize;
+            size -= sizeBlock;
+            sizeBlock = this.nBlockSize;
             iBlock++;
         }
         return fClean;

versions/pcx86/1.36.0/pcx86-uncompiled.js

@@ -8593,12 +8593,14 @@ class Bus extends Component {
     {
         var fClean = true;
         var iBlock = addr >>> this.nBlockShift;
+        var sizeBlock = this.nBlockSize - (addr & this.nBlockLimit);
         while (size > 0 && iBlock < this.aMemBlocks.length) {
             if (this.aMemBlocks[iBlock].fDirty) {
                 this.aMemBlocks[iBlock].fDirty = fClean = false;
                 this.aMemBlocks[iBlock].fDirtyEver = true;
             }
-            size -= this.nBlockSize;
+            size -= sizeBlock;
+            sizeBlock = this.nBlockSize;
             iBlock++;
         }
         return fClean;

versions/pdpjs/1.36.0/pdp10-uncompiled.js

@@ -5762,12 +5762,14 @@ class BusPDP10 extends Component {
     {
         var fClean = true;
         var iBlock = addr >>> this.nBlockShift;
+        var sizeBlock = this.nBlockSize - (addr & this.nBlockLimit);
         while (size > 0 && iBlock < this.aBusBlocks.length) {
             if (this.aBusBlocks[iBlock].fDirty) {
                 this.aBusBlocks[iBlock].fDirty = fClean = false;
                 this.aBusBlocks[iBlock].fDirtyEver = true;
             }
-            size -= this.nBlockSize;
+            size -= sizeBlock;
+            sizeBlock = this.nBlockSize;
             iBlock++;
         }
         return fClean;

versions/pdpjs/1.36.0/pdp11-uncompiled.js

@@ -6943,12 +6943,14 @@ class BusPDP11 extends Component {
     {
         var fClean = true;
         var iBlock = addr >>> this.nBlockShift;
+        var sizeBlock = this.nBlockSize - (addr & this.nBlockLimit);
         while (size > 0 && iBlock < this.aBusBlocks.length) {
             if (this.aBusBlocks[iBlock].fDirty) {
                 this.aBusBlocks[iBlock].fDirty = fClean = false;
                 this.aBusBlocks[iBlock].fDirtyEver = true;
             }
-            size -= this.nBlockSize;
+            size -= sizeBlock;
+            sizeBlock = this.nBlockSize;
             iBlock++;
         }
         return fClean;