Retro/pcjs
Watch
1
0
Fork
You've already forked pcjs
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixed old, longstanding, and surprisingly bad bug in cleanMemory() for all machine implementations

Browse source
This commit is contained in:
Jeff Parsons 2017-07-12 21:02:30 -07:00 • committed by Jeff Parsons
commit ec438be5c9
24 changed files with 145 additions and 128 deletions
Download patch file Download diff file Expand all files Collapse all files

4
modules/pc6502/lib/bus.js
View file

@ -264,12 +264,14 @@ Bus.prototype.cleanMemory = function(addr, size)
{
var fClean = true;
var iBlock = addr >>> this.nBlockShift;
var sizeBlock = this.nBlockSize - (addr & this.nBlockLimit);
while (size > 0 && iBlock < this.aMemBlocks.length) {
if (this.aMemBlocks[iBlock].fDirty) {
this.aMemBlocks[iBlock].fDirty = fClean = false;
this.aMemBlocks[iBlock].fDirtyEver = true;
}
size -= this.nBlockSize;
size -= sizeBlock;
sizeBlock = this.nBlockSize;
iBlock++;
}
return fClean;

4
modules/pc8080/lib/bus.js
View file

@ -296,12 +296,14 @@ class Bus8080 extends Component {
{
var fClean = true;
var iBlock = addr >>> this.nBlockShift;
var sizeBlock = this.nBlockSize - (addr & this.nBlockLimit);
while (size > 0 && iBlock < this.aMemBlocks.length) {
if (this.aMemBlocks[iBlock].fDirty) {
this.aMemBlocks[iBlock].fDirty = fClean = false;
this.aMemBlocks[iBlock].fDirtyEver = true;
}
size -= this.nBlockSize;
size -= sizeBlock;
sizeBlock = this.nBlockSize;
iBlock++;
}
return fClean;

4
modules/pcx86/lib/bus.js
View file

@ -345,12 +345,14 @@ class Bus extends Component {
{
var fClean = true;
var iBlock = addr >>> this.nBlockShift;
var sizeBlock = this.nBlockSize - (addr & this.nBlockLimit);
while (size > 0 && iBlock < this.aMemBlocks.length) {
if (this.aMemBlocks[iBlock].fDirty) {
this.aMemBlocks[iBlock].fDirty = fClean = false;
this.aMemBlocks[iBlock].fDirtyEver = true;
}
size -= this.nBlockSize;
size -= sizeBlock;
sizeBlock = this.nBlockSize;
iBlock++;
}
return fClean;

4
modules/pdp10/lib/bus.js
View file

@ -327,12 +327,14 @@ class BusPDP10 extends Component {
{
var fClean = true;
var iBlock = addr >>> this.nBlockShift;
var sizeBlock = this.nBlockSize - (addr & this.nBlockLimit);
while (size > 0 && iBlock < this.aBusBlocks.length) {
if (this.aBusBlocks[iBlock].fDirty) {
this.aBusBlocks[iBlock].fDirty = fClean = false;
this.aBusBlocks[iBlock].fDirtyEver = true;
}
size -= this.nBlockSize;
size -= sizeBlock;
sizeBlock = this.nBlockSize;
iBlock++;
}
return fClean;

4
modules/pdp11/lib/bus.js
View file

@ -475,12 +475,14 @@ class BusPDP11 extends Component {
{
var fClean = true;
var iBlock = addr >>> this.nBlockShift;
var sizeBlock = this.nBlockSize - (addr & this.nBlockLimit);
while (size > 0 && iBlock < this.aBusBlocks.length) {
if (this.aBusBlocks[iBlock].fDirty) {
this.aBusBlocks[iBlock].fDirty = fClean = false;
this.aBusBlocks[iBlock].fDirtyEver = true;
}
size -= this.nBlockSize;
size -= sizeBlock;
sizeBlock = this.nBlockSize;
iBlock++;
}
return fClean;