Retro/pcjs
Watch
1
0
Fork
You've already forked pcjs
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Avoid deprecation warnings regarding image smoothing, by carefully checking for properties in order of least to most deprecatable (what a delightful process)

Browse source
This commit is contained in:
Jeff Parsons 2016-05-04 13:16:37 -07:00
commit cf596ee224
10 changed files with 349 additions and 343 deletions
Download patch file Download diff file Expand all files Collapse all files

9
modules/pc8080/lib/video.js
View file

@ -89,7 +89,7 @@ function Video(parmsVideo, canvas, context, textarea, container)
{
var video = this;
this.fGecko = web.isUserAgent("Gecko/");
var i, sEvent, asWebPrefixes = ['', 'moz', 'webkit', 'ms'];
var i, sEvent, asWebPrefixes = ['', 'moz', 'ms', 'webkit'];
Component.call(this, "Video", parmsVideo, Video, Messages.VIDEO);
@ -137,7 +137,10 @@ function Video(parmsVideo, canvas, context, textarea, container)
} else {
sEvent += 'ImageSmoothingEnabled';
}
this.contextScreen[sEvent] = fSmoothing;
if (this.contextScreen[sEvent] !== undefined) {
this.contextScreen[sEvent] = fSmoothing;
break;
}
}
}
@ -185,7 +188,7 @@ function Video(parmsVideo, canvas, context, textarea, container)
sEvent = asWebPrefixes[i] + 'fullscreenchange';
if ('on' + sEvent in document) {
var onFullScreenChange = function() {
var fFullScreen = (document['fullscreenElement'] || document['mozFullScreenElement'] || document['webkitFullscreenElement'] || document['msFullscreenElement']);
var fFullScreen = (document['fullscreenElement'] || document['msFullscreenElement'] || document['mozFullScreenElement'] || document['webkitFullscreenElement']);
video.notifyFullScreen(fFullScreen? true : false);
};
document.addEventListener(sEvent, onFullScreenChange, false);

9
modules/pcjs/lib/video.js
View file

@ -102,7 +102,7 @@ function Video(parmsVideo, canvas, context, textarea, container)
{
var video = this;
this.fGecko = web.isUserAgent("Gecko/");
var i, sEvent, asWebPrefixes = ['', 'moz', 'webkit', 'ms'];
var i, sEvent, asWebPrefixes = ['', 'moz', 'ms', 'webkit'];
Component.call(this, "Video", parmsVideo, Video, Messages.VIDEO);
@ -174,7 +174,10 @@ function Video(parmsVideo, canvas, context, textarea, container)
} else {
sEvent += 'ImageSmoothingEnabled';
}
this.contextScreen[sEvent] = fSmoothing;
if (this.contextScreen[sEvent] !== undefined) {
this.contextScreen[sEvent] = fSmoothing;
break;
}
}
}
@ -240,7 +243,7 @@ function Video(parmsVideo, canvas, context, textarea, container)
sEvent = asWebPrefixes[i] + 'fullscreenchange';
if ('on' + sEvent in document) {
var onFullScreenChange = function() {
var fFullScreen = (document['fullscreenElement'] || document['mozFullScreenElement'] || document['webkitFullscreenElement'] || document['msFullscreenElement']);
var fFullScreen = (document['fullscreenElement'] || document['msFullscreenElement'] || document['mozFullScreenElement'] || document['webkitFullscreenElement']);
video.notifyFullScreen(fFullScreen? true : false);
};
document.addEventListener(sEvent, onFullScreenChange, false);