Retro/pcjs
Watch
1
0
Fork
You've already forked pcjs
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Follow my own advice and write any 32-bit hex constant > 0x7fffffff as (constant|0)

Browse source 
The Closure Compiler does a fine job of replacing all such expressions with their decimal equivalent, relieving us from having to calculate them ourselves, and eliminating any runtime impact
This commit is contained in:
Jeff Parsons 2015-02-19 11:18:40 -08:00 • committed by jeffpar
commit c8aec14b0b
153 changed files with 6296 additions and 188 deletions
Download patch file Download diff file Expand all files Collapse all files

10
modules/pcjs/lib/x86opxx.js
View file

@ -1337,8 +1337,8 @@ var X86OpXX = {
opOS: function() {
if (I386) {
this.opFlags |= X86.OPFLAG.SEG;
this.dataSize ^= 0x6; // that which is 2 shall become 4, and vice versa
this.dataMask ^= 0xffff0000; // that which is 0x0000ffff shall become 0xffffffff, and vice versa
this.dataSize ^= 0x6; // that which is 2 shall become 4, and vice versa
this.dataMask ^= (0xffff0000|0); // that which is 0x0000ffff shall become 0xffffffff, and vice versa
this.opMem = this.aaOpMem[this.dataSize];
this.nStepCycles -= this.CYCLES.nOpCyclesPrefix;
}
@ -1353,8 +1353,8 @@ var X86OpXX = {
opAS: function() {
if (I386) {
this.opFlags |= X86.OPFLAG.SEG;
this.addrSize ^= 0x06; // that which is 2 shall become 4, and vice versa
this.addrMask ^= 0xffff0000; // that which is 0x0000ffff shall become 0xffffffff, and vice versa
this.addrSize ^= 0x06; // that which is 2 shall become 4, and vice versa
this.addrMask ^= (0xffff0000|0); // that which is 0x0000ffff shall become 0xffffffff, and vice versa
this.setOpMod();
this.nStepCycles -= this.CYCLES.nOpCyclesPrefix;
}
@ -2221,7 +2221,7 @@ var X86OpXX = {
/*
* CDQ
*/
this.regEDX = (this.regEAX & 0x80000000)? 0xffffffff : 0;
this.regEDX = (this.regEAX & (0x80000000|0))? -1 : 0;
}
this.nStepCycles -= this.CYCLES.nOpCyclesCWD;
},