Retro/pcjs
Watch
1
0
Fork
You've already forked pcjs
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Future-proof ADDR_INVALID checks by using strict [in]equality

Browse source
This commit is contained in:
Jeff Parsons 2015-05-14 13:11:46 -07:00 • committed by jeffpar
commit c431e5dde8
3 changed files with 10 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

2
modules/pcjs/lib/x86seg.js
View file

@ -982,7 +982,7 @@ X86Seg.prototype.updateMode = function(fLoad, fProt)
* hardware does not update it either. In fact, I've seen code that uses the null GDT descriptor
* for other purposes, on the assumption that that descriptor is completely unused.
*/
if ((this.sel & ~X86.SEL.RPL) && this.addrDesc != X86.ADDR_INVALID) {
if ((this.sel & ~X86.SEL.RPL) && this.addrDesc !== X86.ADDR_INVALID) {
var addrACC = this.addrDesc + X86.DESC.ACC.TYPE.OFFSET;
this.cpu.setByte(addrACC, this.cpu.getByte(addrACC) | (X86.DESC.ACC.TYPE.ACCESSED >> 8));
}