Retro/pcjs
Watch
1
0
Fork
You've already forked pcjs
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Eliminated an outdated TODO

Browse source
This commit is contained in:
Jeff Parsons 2017-08-03 08:18:35 -07:00 • committed by Jeff Parsons
commit c397937a87
4 changed files with 6 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

7
modules/pcx86/lib/computer.js
View file

@ -780,11 +780,8 @@ class Computer extends Component {
* Object or a string), but components are supposed to store only Objects, so if a * Object or a string), but components are supposed to store only Objects, so if a
* string comes back, something went wrong. By explicitly eliminating "string" data, * string comes back, something went wrong. By explicitly eliminating "string" data,
* the Closure Compiler stops complaining that we might be passing strings to our * the Closure Compiler stops complaining that we might be passing strings to our
* powerUp() functions (even though we know we're not). * powerUp() functions (even though we know we're not). We could also add @type
* * overrides to the data assignments, but this seems like a useful runtime check.
* TODO: Determine if there's some way to coerce the Closure Compiler into treating
* data as Object or null, without having to include this runtime check. An assert
* would be a good idea, but this is overkill.
*/ */
if (typeof data === "string") data = null; if (typeof data === "string") data = null;

2
versions/pcx86/1.36.0/pcx86-dbg.map
View file

File diff suppressed because one or more lines are too long

7
versions/pcx86/1.36.0/pcx86-uncompiled.js
View file

@ -75430,11 +75430,8 @@ class Computer extends Component {
* Object or a string), but components are supposed to store only Objects, so if a * Object or a string), but components are supposed to store only Objects, so if a
* string comes back, something went wrong. By explicitly eliminating "string" data, * string comes back, something went wrong. By explicitly eliminating "string" data,
* the Closure Compiler stops complaining that we might be passing strings to our * the Closure Compiler stops complaining that we might be passing strings to our
* powerUp() functions (even though we know we're not). * powerUp() functions (even though we know we're not). We could also add @type
* * overrides to the data assignments, but this seems like a useful runtime check.
* TODO: Determine if there's some way to coerce the Closure Compiler into treating
* data as Object or null, without having to include this runtime check. An assert
* would be a good idea, but this is overkill.
*/ */
if (typeof data === "string") data = null; if (typeof data === "string") data = null;

2
versions/pcx86/1.36.0/pcx86.map
View file

File diff suppressed because one or more lines are too long