Retro/pcjs
Watch
1
0
Fork
You've already forked pcjs
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make Int36 toDecimal() more paranoid (we want perfect output, or no output at all)

Browse source
This commit is contained in:
Jeff Parsons 2017-02-18 09:28:43 -08:00 • committed by Jeff Parsons
commit acdf89ec54
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
modules/shared/lib/int36.js
View file

@ -240,15 +240,15 @@ class Int36 {
i36Tmp.negate(); i36Tmp.negate();
fNeg = true; fNeg = true;
} }
/*
* Conversion of any 72-bit value should take no more than 3 divisions by 10,000,000,000.
*/
var nMaxDivs = 3; var nMaxDivs = 3;
do { do {
i36Tmp.div(i36Div); i36Tmp.div(i36Div);
/* /*
* In a perfect world, there would be no errors, because all Int36 calculations at * In a perfect world, there would be no errors, because all calculations at this point
* this point should be positive values, the remainder should always be less than the * are within known bounds. But let's make sure we don't produce garbage or spin our wheels.
* divisor, and the entire process should complete within 3 divisions. But until then,
* let's make sure we don't produce garbage or spin our wheels.
*/ */
if (i36Tmp.error || i36Tmp.remainder >= 10000000000 || !nMaxDivs--) { if (i36Tmp.error || i36Tmp.remainder >= 10000000000 || !nMaxDivs--) {
s = "error"; s = "error";