Retro/pcjs
Watch
1
0
Fork
You've already forked pcjs
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Added some iOS usability improvements (related to soft keys/buttons and annoying focus/zoom changes)

Browse source
This commit is contained in:
Jeff Parsons 2016-08-23 16:08:48 -07:00
commit 97f8e87ca3
4 changed files with 186 additions and 173 deletions
Download patch file Download diff file Expand all files Collapse all files

11
modules/pc8080/lib/keyboard.js
View file

@ -494,6 +494,11 @@ Keyboard8080.prototype.setBinding = function(sHTMLType, sBinding, control, sValu
this.bindings[id] = control;
var fnDown = function(kbd, softCode) {
return function onKeyboardBindingDown(event) {
/*
* iOS Usability Improvement: Calling preventDefault() prevents rapid clicks from
* also being (mis)interpreted as a desire to "zoom" in on the machine.
*/
event.preventDefault();
kbd.onSoftKeyDown(softCode, true);
/*
* I'm assuming we only need to give focus back on the "up" event...
@ -507,8 +512,12 @@ Keyboard8080.prototype.setBinding = function(sHTMLType, sBinding, control, sValu
kbd.onSoftKeyDown(softCode, false);
/*
* Give focus back to the machine (since clicking the button takes focus away).
*
* if (kbd.cmp) kbd.cmp.updateFocus();
*
* iOS Usability Improvement: NOT calling updateFocus() keeps the soft keyboard down
* (assuming it was already down).
*/
if (kbd.cmp) kbd.cmp.updateFocus();
};
}(this, this.config.SOFTCODES[sBinding]);
if ('ontouchstart' in window) {

6
modules/pc8080/lib/serialport.js
View file

@ -369,8 +369,12 @@ SerialPort8080.prototype.setBinding = function(sHTMLType, sBinding, control, sVa
serial.receiveData(sValue);
/*
* Give focus back to the machine (since clicking the button takes focus away).
*
* if (serial.cmp) serial.cmp.updateFocus();
*
* iOS Usability Improvement: NOT calling updateFocus() keeps the soft keyboard down
* (assuming it was already down).
*/
if (serial.cmp) serial.cmp.updateFocus();
return true;
};
return true;