Retro/pcjs
Watch
1
0
Fork
You've already forked pcjs
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixed SerialPort Ctrl-key processing for Windows-based browsers

Browse source
This commit is contained in:
Jeff Parsons 2015-08-14 16:46:24 -07:00
commit 94dad8cbb5
1 changed files with 12 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

16
modules/pcjs/lib/serialport.js
View file

@ -338,30 +338,38 @@ SerialPort.prototype.setBinding = function(sHTMLType, sBinding, control)
* This is required in addition to onkeypress, because it's the only way to prevent * This is required in addition to onkeypress, because it's the only way to prevent
* BACKSPACE (keyCode 8) from being interpreted by the browser as a "Back" operation; * BACKSPACE (keyCode 8) from being interpreted by the browser as a "Back" operation;
* moreover, not all browsers generate an onkeypress notification for BACKSPACE. * moreover, not all browsers generate an onkeypress notification for BACKSPACE.
*
* A related problem exists for Ctrl-key combinations in most Windows-based browsers
* (eg, IE, Edge, Chrome for Windows, etc), because keys like Ctrl-C and Ctrl-S have
* special meanings (eg, Copy, Save). To the extent the browser will allow it, we
* attempt to disable that default behavior when this control receives an onkeydown
* event for one of those keys (which is probably the only event the browser will generate).
*/ */
event = event || window.event; event = event || window.event;
var keyCode = event.keyCode; var keyCode = event.keyCode;
if (keyCode === 8) { if (keyCode === 0x08 || keyCode >= 0x41 && keyCode <= 0x5A && (event.ctrlKey || event.metaKey)) {
if (event.preventDefault) event.preventDefault(); if (event.preventDefault) event.preventDefault();
if (keyCode > 0x40) keyCode -= 0x40;
serial.sendRBR([keyCode]); serial.sendRBR([keyCode]);
return true;
} }
return true;
}; };
control.onkeypress = function onKeyPressSerial(event) { control.onkeypress = function onKeyPressSerial(event) {
/* /*
* Browser-independent keyCode extraction (refer to keyPress() and the other key * Browser-independent keyCode extraction (refer to keyPress() and the other key
* event handlers in keyboard.js). * event handlers in keyboard.js).
* *
* The additional check for SPACE (keyCode 32) and subsequent preventDefault() call * The additional check for SPACE (keyCode 0x20) and subsequent preventDefault() call
* prevents SPACE from bubbling up to the document event handlers, where its default * prevents SPACE from bubbling up to the document event handlers, where its default
* behavior is typically to scroll the entire page -- a real nuisance. * behavior is typically to scroll the entire page -- a real nuisance.
*/ */
event = event || window.event; event = event || window.event;
var keyCode = event.which || event.keyCode; var keyCode = event.which || event.keyCode;
serial.sendRBR([keyCode]); serial.sendRBR([keyCode]);
if (keyCode == 32) { if (keyCode == 0x20) {
if (event.preventDefault) event.preventDefault(); if (event.preventDefault) event.preventDefault();
} }
return true;
}; };
return true; return true;