Retro/pcjs
Watch
1
0
Fork
You've already forked pcjs
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Leave CPU references in Memory blocks alone

Browse source
This commit is contained in:
Jeff Parsons 2015-08-05 11:21:42 -07:00
commit 5a9348c75f
1 changed files with 1 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
modules/pcjs/lib/memory.js
View file

@ -557,8 +557,7 @@ Memory.prototype = {
* NOTE: If this Memory block is not an UNPAGED block that might need to call cpu.mapPageBlock()), and it no * NOTE: If this Memory block is not an UNPAGED block that might need to call cpu.mapPageBlock()), and it no
* longer has any read or write breakpoints associated with it, then it no longer needs a CPU reference. The * longer has any read or write breakpoints associated with it, then it no longer needs a CPU reference. The
* existence of a CPU reference only impacts the performance of the "checked" memory access functions, so it's * existence of a CPU reference only impacts the performance of the "checked" memory access functions, so it's
* not critical to eliminate it, but we do it anyway, in case the "checked" functions become re-enabled later * not critical to eliminate it.
* (eg, by the Debugger -- yeah, the Debugger, which is why eliminating it isn't critical).
* *
* TODO: Another option would be to count CPU references separately from Debugger references, so that when the * TODO: Another option would be to count CPU references separately from Debugger references, so that when the
* former goes to zero, we can unconditionally remove the CPU reference; UNPAGED blocks would automatically * former goes to zero, we can unconditionally remove the CPU reference; UNPAGED blocks would automatically
@ -583,7 +582,6 @@ Memory.prototype = {
} }
Component.assert(this.cWriteBreakpoints >= 0); Component.assert(this.cWriteBreakpoints >= 0);
} }
if (!this.cReadBreakpoints && !this.cWriteBreakpoints && this.type != Memory.TYPE.UNPAGED) this.cpu = null;
}, },
/** /**
* readNone(off) * readNone(off)