Retro/pcjs
Watch
1
0
Fork
You've already forked pcjs
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Simplify favicon hosting

Browse source 
This is essentially what the old code did, but without using the deprecated connect-favicon middleware.

The meta tag on pages is redundant, but it's still a good idea to keep it around (and maybe supplement it with tags that link to the icon in simpler, straightforward image formats like PNG).
This commit is contained in:
Stuart P. Bentley 2015-09-27 02:45:17 -07:00
commit 0e7151f975
1 changed files with 2 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

12
server.js
View file

@ -78,16 +78,6 @@ var app = express();
app.enable("strict routing");
app.set('port', args.argv['port'] || process.env.PORT || 8088);
/*
* I already include the following in the <head> tag of my HTML documents:
*
* <link rel="shortcut icon" href="/versions/images/current/favicon.ico" type="image/x-icon">
*
* and if remove that line, browsers stop displaying my favicon, so I'm not sure what the
* following code is doing for me. TODO: Find out!
*/
app.use(express.favicon(path.join(sServerRoot, "./versions/images/current/favicon.ico")));
/*
* For more information about express.logger():
*
@ -133,6 +123,8 @@ app.use(function(req, res, next) {
});
app.use(express.static(sServerRoot));
/* Serve favicon at site root */
app.use('/favicon.ico', express.static(path.join(sServerRoot, "versions/images/current/favicon.ico")));
app.use(slash());
var server = http.createServer(app).listen(app.get('port'), function() {