Demos/jsxm
Watch
1
0
Fork
You've already forked jsxm
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

added test for vibrato... and fixed vibrato

Browse source 
naturally when i actually tested it, it turned out to be subtly broken

also reorg'd the tests a bit, sorry @hillerstorm.
This commit is contained in:
Andy Sloane 2015-11-13 22:06:50 -08:00
commit 570aa33a20
6 changed files with 104 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

5
xmeffects.js
View file

@ -61,13 +61,14 @@ function eff_t0_4(ch, data) { // vibrato
if (data >> 4) {
ch.vibratospeed = data >> 4;
}
eff_t1_4(ch, data);
eff_t1_4(ch);
}
function eff_t1_4(ch) { // vibrato
ch.periodoffset = Math.sin(ch.vibratopos * Math.PI / 32) * ch.vibratodepth;
if (isNaN(ch.periodoffset)) {
console.log("vibrato periodoffset NaN?", ch.vibratopos, ch.vibratodepth);
console.log("vibrato periodoffset NaN?",
ch.vibratopos, ch.vibratospeed, ch.vibratodepth);
ch.periodoffset = 0;
}
ch.vibratopos += ch.vibratospeed;